search

GoogleChromeLabs / sw-toolbox

[Deprecated] A collection of service worker tools for offlining runtime requests
https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-sw
Apache License 2.0
3.62k stars 331 forks source link

add typings support #225

Closed tusharmath closed 7 years ago

tusharmath commented 7 years ago

fixes #183

Have written it based on the API docs.

jeffposnick commented 7 years ago

Thanks, @tusharmath! I don't have experience working with TypeScript, but I'm going to try to find some colleagues to review. In the meantime, I believe that you'd also want to include the index.d.ts file in the list of things that get packaged up for npm, i.e. add it to the files array in package.json. Could you do that in this PR as well?

wibblymat commented 7 years ago

@jeffposnick I believe that it Just Works if you put the index.d.ts file in the project, without further config.

wibblymat commented 7 years ago

@jeffposnick nvm, crossed wires - I was talking about something else.

tusharmath commented 7 years ago

Should we bundle the following definations with the package ?

tusharmath commented 7 years ago

@wibblymat @jeffposnick Is there any other feedback?

wibblymat commented 7 years ago

Everything LGTM, but maybe @jeffposnick has more to say.

jeffposnick commented 7 years ago

👍

tusharmath commented 7 years ago

@jeffposnick Is this not published?

jeffposnick commented 7 years ago

Not as of yet. Publishing a patch-level release that includes it is on my TODO list.

tusharmath commented 7 years ago

Thanks.

On Wed, Feb 22, 2017, 12:06 AM Jeffrey Posnick notifications@github.com wrote:

Not as of yet. Publishing a patch-level release that includes it is on my TODO list.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/sw-toolbox/pull/225#issuecomment-281435406, or mute the thread https://github.com/notifications/unsubscribe-auth/AAL3ssOSIOhtJn0lhnXw7vw9IcyBFizNks5rey6vgaJpZM4MEPeM .

-- Regards, Tushar Mathur. www.tusharm.com

jeffposnick commented 7 years ago

This is now published on npm in the 3.6.0 release.