GoogleChromeLabs / sw-toolbox

[Deprecated] A collection of service worker tools for offlining runtime requests
https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-sw
Apache License 2.0
3.61k stars 331 forks source link

Ignore test directory in bower.json #264

Closed MCRayRay closed 7 years ago

MCRayRay commented 7 years ago

Previously we were ignoring anything matching the glob pattern 'tests'. This looks like a typo to me as there is no file/directory in the root called that. There is, however, a 'tests' directory, which I presume this line was intended to catch.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


jeffposnick commented 7 years ago

Thanks for the contribution!

If you're able to sign the CLA, I'll merge.

MCRayRay commented 7 years ago

Hi, Jeffrey.

I have signed the CLA as an individual under the email address ghost5786@gmail.com.

On 7 Aug 2017 7:41 pm, "Jeffrey Posnick" notifications@github.com wrote:

Thanks for the contribution!

If you're able to sign the CLA, I'll merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/sw-toolbox/pull/264#issuecomment-320746282, or mute the thread https://github.com/notifications/unsubscribe-auth/ACtlNVV0rWRxGP3YSwW6-6FcRvCcH_-Wks5sV1pDgaJpZM4OudU_ .

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

MCRayRay commented 7 years ago

Hi, Jeffrey.

I just realised I signed the CLA under another email address instead of the one I used for the commit. So, I have signed the CLA under markcharlesraymond@gmail.com, which should be the one matching the commit.

On 07/08/2017 19:41, Jeffrey Posnick wrote:

Thanks for the contribution!

If you're able to sign the CLA, I'll merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChrome/sw-toolbox/pull/264#issuecomment-320746282, or mute the thread https://github.com/notifications/unsubscribe-auth/ACtlNVV0rWRxGP3YSwW6-6FcRvCcH_-Wks5sV1pDgaJpZM4OudU_.

googlebot commented 7 years ago

CLAs look good, thanks!

jeffposnick commented 7 years ago

Thanks!