search

GoogleChromeLabs / sw-toolbox

[Deprecated] A collection of service worker tools for offlining runtime requests
https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-sw
Apache License 2.0
3.61k stars 331 forks source link

Consider bumping `path-to-regexp`. #278

Closed wtgtybhertgeghgtwtg closed 6 years ago

wtgtybhertgeghgtwtg commented 6 years ago

The currently required version uses is-array, which is a polyfill for Array.isArray. Bumping it to path-to-regexp@2 makes that go away. It's not a big deal, but it might be a good idea. I have a branch ready if you'd like a PR.

jeffposnick commented 6 years ago

Generally speaking, we're not planning on additional releases of sw-toolbox, as the team's efforts are focused on Workbox: https://github.com/GoogleChromeLabs/sw-toolbox#what-does-this-mean-for-sw-toolbox

(Critical bugs or security issues are still being addressed.)