GoogleChromeLabs / text-app

A text editor for ChromeOS and Chrome
https://chrome.google.com/webstore/detail/mmfbcljfglbokpmkimbfghdkjmjhdgbg
Other
554 stars 148 forks source link

Open from Chrome "Files" shows the wrong file #506

Open projectasia opened 4 years ago

projectasia commented 4 years ago

If the app is already running, Open (using left menu), or opening from Chrome File manager (right click, open with...) works fine.

If the app is not running, then opening a file from Chrome file manager launches the txt app running, but the app does not select the newly opened file as the front-most focus. It selects a previous edited file, which is very confusing.

Double click a file = seeing some old file I edited in the past in text-app.

BugsNash commented 4 years ago

Hi projectasia, thanks for filing :)

I am not able to reproduce this.

Steps taken: 1) Open text app and edit a file 'hi.txt' 2) Save 'hi.txt'. 3) Close text app. 4) In files app, double click to open a different file 'asd.txt' with text app (which is set to the default).

What I see:

Let me know if the reprot steps I am taking are incorrect!

projectasia commented 4 years ago

wow thanks for checking. I did do some testing and i cannot recreate at the moment using your simple test.

But i did notice the recent list gets bigger and bigger, more than the files I have opened. So now i think there is a recent list bug, which might lead to the wrong index being shown. double click some files (txt, sh, and html), dont edit. close the app mouse [X] in upper right double click some more files. click upper right [x] double click some more random files, suddenly the file list is repeating (see photo) using control-W, over and over, I cannot close the list. it seems nearly infinite

On Sun, May 10, 2020 at 4:36 PM Bugs Nash notifications@github.com wrote:

Hi projectasia, thanks for filing :)

I am not able to reproduce this.

Steps taken:

  1. Open text app and edit a file 'hi.txt'
  2. Save 'hi.txt'.
  3. Close text app.
  4. In files app, double click to open a different file 'asd.txt' with text app (which is set to the default).

What I see:

  • asd.txt is opened in the text app and is the focus
  • hi.txt is in the list of open files but is not in focus.

Let me know if the reprot steps I am taking are incorrect!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChromeLabs/text-app/issues/506#issuecomment-626407235, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQ6IDG34BUDGNFSXSBHUUTRQ43BFANCNFSM4M5M76CQ .

projectasia commented 4 years ago

Look for foo in this image. Somehow repeated many times? This might be my chromebook and not the app. Let me try to capture a video

On Sun, May 10, 2020, 7:32 PM Marc Weiss marc.andrew.weiss@gmail.com wrote:

wow thanks for checking. I did do some testing and i cannot recreate at the moment using your simple test.

But i did notice the recent list gets bigger and bigger, more than the files I have opened. So now i think there is a recent list bug, which might lead to the wrong index being shown. double click some files (txt, sh, and html), dont edit. close the app mouse [X] in upper right double click some more files. click upper right [x] double click some more random files, suddenly the file list is repeating (see photo) using control-W, over and over, I cannot close the list. it seems nearly infinite

On Sun, May 10, 2020 at 4:36 PM Bugs Nash notifications@github.com wrote:

Hi projectasia, thanks for filing :)

I am not able to reproduce this.

Steps taken:

  1. Open text app and edit a file 'hi.txt'
  2. Save 'hi.txt'.
  3. Close text app.
  4. In files app, double click to open a different file 'asd.txt' with text app (which is set to the default).

What I see:

  • asd.txt is opened in the text app and is the focus
  • hi.txt is in the list of open files but is not in focus.

Let me know if the reprot steps I am taking are incorrect!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChromeLabs/text-app/issues/506#issuecomment-626407235, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQ6IDG34BUDGNFSXSBHUUTRQ43BFANCNFSM4M5M76CQ .

projectasia commented 4 years ago

Try to recreate this bug. I will try to come up with a reproducible case for wrong file.

On Sun, May 10, 2020, 7:32 PM Marc Weiss marc.andrew.weiss@gmail.com wrote:

wow thanks for checking. I did do some testing and i cannot recreate at the moment using your simple test.

But i did notice the recent list gets bigger and bigger, more than the files I have opened. So now i think there is a recent list bug, which might lead to the wrong index being shown. double click some files (txt, sh, and html), dont edit. close the app mouse [X] in upper right double click some more files. click upper right [x] double click some more random files, suddenly the file list is repeating (see photo) using control-W, over and over, I cannot close the list. it seems nearly infinite

On Sun, May 10, 2020 at 4:36 PM Bugs Nash notifications@github.com wrote:

Hi projectasia, thanks for filing :)

I am not able to reproduce this.

Steps taken:

  1. Open text app and edit a file 'hi.txt'
  2. Save 'hi.txt'.
  3. Close text app.
  4. In files app, double click to open a different file 'asd.txt' with text app (which is set to the default).

What I see:

  • asd.txt is opened in the text app and is the focus
  • hi.txt is in the list of open files but is not in focus.

Let me know if the reprot steps I am taking are incorrect!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChromeLabs/text-app/issues/506#issuecomment-626407235, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQ6IDG34BUDGNFSXSBHUUTRQ43BFANCNFSM4M5M76CQ .

projectasia commented 4 years ago

https://photos.app.goo.gl/tKD97MiEiPpZvf1d7

On Sun, May 10, 2020, 7:32 PM Marc Weiss marc.andrew.weiss@gmail.com wrote:

wow thanks for checking. I did do some testing and i cannot recreate at the moment using your simple test.

But i did notice the recent list gets bigger and bigger, more than the files I have opened. So now i think there is a recent list bug, which might lead to the wrong index being shown. double click some files (txt, sh, and html), dont edit. close the app mouse [X] in upper right double click some more files. click upper right [x] double click some more random files, suddenly the file list is repeating (see photo) using control-W, over and over, I cannot close the list. it seems nearly infinite

On Sun, May 10, 2020 at 4:36 PM Bugs Nash notifications@github.com wrote:

Hi projectasia, thanks for filing :)

I am not able to reproduce this.

Steps taken:

  1. Open text app and edit a file 'hi.txt'
  2. Save 'hi.txt'.
  3. Close text app.
  4. In files app, double click to open a different file 'asd.txt' with text app (which is set to the default).

What I see:

  • asd.txt is opened in the text app and is the focus
  • hi.txt is in the list of open files but is not in focus.

Let me know if the reprot steps I am taking are incorrect!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleChromeLabs/text-app/issues/506#issuecomment-626407235, or unsubscribe https://github.com/notifications/unsubscribe-auth/APQ6IDG34BUDGNFSXSBHUUTRQ43BFANCNFSM4M5M76CQ .

BugsNash commented 4 years ago

Thanks projectasia! I actually filed #507 earlier today which I noticed when I was investigating this issue. Have added notes about the expanding file list to that issue as it seems like it could be the same underlying problem.

xbootnek commented 4 years ago

I have a similar issue with Chrome on a ChromeBox while opening a Google Drive file; the file opened is the previous file opened by the editor. This happens in all cases: after a restart and after closing and re-opening the extension. The extension worked correctly initially but the file name index seems to have gotten screwed up.