GoogleChromeLabs / text-app

A text editor for ChromeOS and Chrome
https://chrome.google.com/webstore/detail/mmfbcljfglbokpmkimbfghdkjmjhdgbg
Other
554 stars 148 forks source link

set proper keyboard shortcuts for Save and Save As actions #524

Closed Mystael closed 4 years ago

Mystael commented 4 years ago

As it was mentioned in this issue, keyboard shortcuts for save and save as actions do not behave like in most of other applications, because they listen to the CapsLock.

After this change it doesn't matter anymore if the CapsLock is turned on or off, as the save as action is invoked by pressing Ctrl+Shift+s or Ctrl+Shift+S keys combination.

google-cla[bot] commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Mystael commented 4 years ago

@googlebot I signed it!

zainafzal08 commented 4 years ago

Very elegant fix! Thanks for the PR :D We'll try to bundle this in with the next release of the text app (sadly it might take a couple weeks to get to you).

BugsNash commented 4 years ago

Fixes #523