GoogleChromeLabs / text-app

A text editor for ChromeOS and Chrome
https://chrome.google.com/webstore/detail/mmfbcljfglbokpmkimbfghdkjmjhdgbg
Other
554 stars 148 forks source link

Update codemirror to 5.60.0 #539

Closed jpalmer closed 1 year ago

jpalmer commented 3 years ago

The old codemirror didn't support zwj sequences for emoji (ref https://github.com/codemirror/CodeMirror/blob/51fdbcc2699c278db1e802663725f56df9ebfce9/doc/releases.html#L143)

Updated codemirror by downloading the latest zip and replacing the existing codemirror folder.

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.