search

GoogleChromeLabs / text-fragments-polyfill

Apache License 2.0
116 stars 27 forks source link

Track `hashchange` event #137

Closed moetelo closed 1 year ago

moetelo commented 2 years ago

Closes #136

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

tfmar commented 2 years ago

Hi Mikhail, is the intent here to support highlighting on same-document links, JS-initiated URL changes, etc? If so, I don't think the spec allows this.

bokand commented 1 year ago

Thanks, lgtm - the only thing I'd check is what happens if the hash changes but the same text fragment is still there (i.e. is it ok for the same snippet to get highlighted multiple times)? I'll defer to @tomayac on overall correctness.