search

GoogleChromeLabs / text-fragments-polyfill

Apache License 2.0
116 stars 27 forks source link

Rename `textStart`==>`start` and `textEnd`==>`end` #148

Open tomayac opened 1 year ago

tomayac commented 1 year ago

Following https://github.com/WICG/scroll-to-text-fragment/pull/218, the present PR reflects these changes here.

Will this also need to be reflected in FragmentDirective? There's currently no IDL for the actual item, but _de factoChrome exposes the names astextStartandtextEnd`.

CC: @bokand

bokand commented 1 year ago

Thanks Thomas! FYI I'm working on brushing up the spec in preparation for upstreaming to HTML - I wouldn't be surprised if there's some back and forth during the review into HTML so for your own sake you might want to wait a bit until the dust settles :)

tomayac commented 1 year ago

Oh, okay. That’s fair. I guess we can just accumulate changes in this PR nonetheless.