search

GoogleChromeLabs / third-party-capital

A library that provides best practices for loading popular third-parties
Apache License 2.0
113 stars 6 forks source link

fix(gtag): access to `gtag()` through `window` #47

Closed huang-julien closed 3 months ago

huang-julien commented 3 months ago

Hi :wave:

This PR make function calls trhough window instead of using global. It is probably better to access it though the window object. Also because this breaks https://github.com/nuxt/scripts/actions/runs/9408083008/job/25915269497?pr=81

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

huang-julien commented 3 months ago

I did patch it in @nuxt/scripts and it does not have any issue :+1: