search

GoogleChromeLabs / third-party-capital

A library that provides best practices for loading popular third-parties
Apache License 2.0
113 stars 6 forks source link

remove window.gtag function #54

Closed flashdesignory closed 1 month ago

flashdesignory commented 1 month ago

should resolve https://github.com/GoogleChromeLabs/third-party-capital/issues/53

@kara

flashdesignory commented 1 month ago

We also need to remove it from types

duh, will do 🤦

harlan-zw commented 1 month ago

happy to have this merged as is but we definitely want to avoid breaking changes like this in the future between patch / minors

flashdesignory commented 1 month ago

happy to have this merged as is but we definitely want to avoid breaking changes like this in the future between patch / minors

Absolutely, breaking changes are possible here, since we're still implementing it and no other framework depends on these changes at the moment.

harlan-zw commented 1 month ago

happy to have this merged as is but we definitely want to avoid breaking changes like this in the future between patch / minors

Absolutely, breaking changes are possible here, since we're still implementing it and no other framework depends on these changes at the moment.

The issue is that you have versioned the package as stable so package managers will update end users' versions whenever you do a patch/minor as third-party-capital is a dependency of Nuxt Scripts.

We can lock the TPC version though as a workaround on our end.