GoogleChromeLabs / third-party-capital

A library that provides best practices for loading popular third-parties
Apache License 2.0
117 stars 8 forks source link

Bring PHP functionality in line with recent JS changes and add integration tests for third parties #70

Closed felixarntz closed 2 months ago

felixarntz commented 2 months ago

Fixes #66.

This PR makes several enhancements:

It may be helpful for the review process to review the individual commits as part of this PR, rather than all changes at once.

Effectively, this PR does everything needed to bring it up to date with the JS codebase, and it includes test coverage to make sure in the future it doesn't get out of date without being noticed.

felixarntz commented 2 months ago

Pushed one more fix here in https://github.com/GoogleChromeLabs/third-party-capital/pull/70/commits/b38ca1214a4742d20037b83c7b3d699ba9eda2e3 because the schema changes from #71 broke PHPUnit tests again.