GoogleChromeLabs / tooling.report

tooling.report a quick way to determine the best build tool for your next web project, or if tooling migration is worth it, or how to adopt a tool's best practice into your existing configuration and code base.
https://tooling.report
Apache License 2.0
848 stars 49 forks source link

Dark theme #307

Closed argyleink closed 4 years ago

argyleink commented 4 years ago

Needed a peaceful morning activity.. wanted to play with HSL and a dark theme. I know Una has one too at #230, but this helped pacify my racing mind. I've done a decent amount of QA, but I might have missed something.

image

github-actions[bot] commented 4 years ago

🚀 Deploy preview for 3b402a9: https://tooling-report--5e4ed8016674d78a.web.app (Fri, 19 Jun 2020 21:04:13 GMT)

firebase-preview-action

argyleink commented 4 years ago
una commented 4 years ago

Is there a benefit to opening a new PR for this work instead of communicating around the initial PR or issue thread? We should discuss next time in advance of work resolving the same issue.

argyleink commented 4 years ago

other PR had merge conflicts and was in a different direction. a new PR lets the original dark work still stand while a new potential can make a suggestion. initial PR also hadnt had any new work on it since original comments, felt stale.

argyleink commented 4 years ago

Una approved ❤️ 👍