GoogleChromeLabs / tooling.report

tooling.report a quick way to determine the best build tool for your next web project, or if tooling migration is worth it, or how to adopt a tool's best practice into your existing configuration and code base.
https://tooling.report
Apache License 2.0
848 stars 49 forks source link

Make the badge tool logos clickable like titles #354

Closed pajaydev closed 4 years ago

pajaydev commented 4 years ago

Fixes https://github.com/GoogleChromeLabs/tooling.report/issues/277

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

pajaydev commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

pajaydev commented 4 years ago

@argyleink Thanks 👍 I have reset the padding. Kindly review and check the below screenshot

Screen Shot 2020-07-02 at 1 33 24 PM
surma commented 4 years ago

(@developit unrelated, any idea why the preview script isn’t running on this one?)

developit commented 4 years ago

@surma I think it only runs on non-fork PRs, because it's not an official GH app.

jakearchibald commented 4 years ago

I'm happy if @argyleink & @una are happy.

jakearchibald commented 4 years ago

Thanks @pajaydev! This change will be on the live site shortly