search

GoogleChromeLabs / tooling.report

tooling.report a quick way to determine the best build tool for your next web project, or if tooling migration is worth it, or how to adopt a tool's best practice into your existing configuration and code base.
https://tooling.report
Apache License 2.0
848 stars 49 forks source link

Merge tool homepages and tool names into `config.js` #383

Open surma opened 4 years ago

surma commented 4 years ago

We have the tool names in config.js.

The tool’s respective homepage URLs are in shared/utils/tool-homepages.ts. We should unify those into config.js.

GeekBoySupreme commented 4 years ago

Hey @surma, would love to fix this. Quick question, in config.js, should the links be in an array like the testSubjects? Or should they be individual variables like in tool-homepages.ts?

surma commented 4 years ago

I was wondering if we should do something like:

export const testSubjects = {
  browserify: {
    name: "Browserify",
    homepage: "http://browserify.org/"
  },
  parcel: {/* ... */},
  /* ... */
};
surma commented 4 years ago

@jakearchibald @developit @argyleink @una

GeekBoySupreme commented 4 years ago

I was wondering if we should do something like:

export const testSubjects = {
  browserify: {
    name: "Browserify",
    homepage: "http://browserify.org/"
  },
  parcel: {/* ... */},
  /* ... */
};

Agreed. Much Structured.

developit commented 4 years ago

Need to update all the usage locations of that config now.

deepanshu44 commented 2 years ago

Hello @surma @developit, is this issue still open for newcomers? I believe @GeekBoySupreme has provided the right solution with this pr, isn't it?