Open GeekBoySupreme opened 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@GeekBoySupreme pretty sure this PR breaks the build as it currently is as we use testSubjects
in a bunch of places throughout the code base. These would need to get adjusted.
Yup, did not get time to work on this yesterday. Have fixed a couple of instances where testSubjects to fix the build. Would be completing that soon.
Okay cool! No rush :)
Roger 🙌
@surma pushed a change and in the config file itself.
Renamed the List to testSubjectsList
and added this bit of code to generate testSubjects
-
export const testSubjects = Object.keys(testSubjectsList).map(key => testSubjectsList[key].name);
Changing the values to fix testSubjects
across all the files was not a really good fix. Hence, implemented this.
383
This PR merges the Tool Homepages from tool-homepages.ts to config.js. Both as an Array and individual variables.