search

GoogleChromeLabs / web-audio-samples

Web Audio API samples by Chrome Web Audio Team
https://bit.ly/web-audio-samples
Apache License 2.0
672 stars 192 forks source link

Adding a manual test for PannerNode #342

Closed hoch closed 11 months ago

hoch commented 11 months ago

This PR adds a manual test for PannerNode, which can be useful when the team verify the PannerNode improvement on issues (e.g. GC, processing artifacts) in the future.

Screenshot 2023-07-10 at 11 22 42 AM

hoch commented 11 months ago

@mjwilson-google PTAL

Using a ConstantSourceNode actually makes this problem much more pronounced - even without any audio, the PannerNode introduces glitches.

hoch commented 11 months ago

A good question. I'll try that and follow up.

hoch commented 11 months ago

The said patch doesn't compile at the moment. I'll merge this first and check back on it later.

mjwilson-google commented 11 months ago

Yes, I see I need to update that patch. I will contact you when it is ready.

mjwilson-google commented 11 months ago

It has been updated.