search

GoogleChromeLabs / web-audio-samples

Web Audio API samples by Chrome Web Audio Team
https://bit.ly/web-audio-samples
Apache License 2.0
672 stars 192 forks source link

fixed ring buffer indexes updates in design patterns #346

Closed grazder closed 8 months ago

grazder commented 8 months ago

Fixed RingBuffer read / write indexes update. Because of that error i faced lags during AudioWorklet process because of that. Faced when RingBuffer length 48000 and kernelBufferSize - 512

google-cla[bot] commented 8 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mjwilson-google commented 8 months ago

Thank you! The fix looks correct to me, but we can't accept your contribution unless we have a CLA on file. Please comment here when the CLA is ready, or if you need help sorting this out.

grazder commented 8 months ago

I think it's ready