Fix: Implemented STOP button behavior to toggle audio playback

tarunsinghofficial commented 3 months ago

The web audio samples lack a stop button functionality, making it difficult for users to pause or stop audio playback once it has started. This limitation hinders the user experience and can be frustrating for individuals testing the demos.

Fix: This PR addresses the issue by implementing a stop button feature in the web audio samples.

Changes Made

Updated build_info.json to reflect changes in the project.
Modified index.njk and main.js files for several audio worklet demos:
- audio-worklet-node-options: Updated options handling for audio worklet nodes.
- hello-audio-worklet: Improved initialization and error handling.
- noise-generator: Enhanced noise generation functionality.
- one-pole-filter: Refinements to the one-pole filter algorithm.
- volume-meter: Improved volume meter visualization and accuracy.
Updated styles.css for better styling and consistency across demos.

Purpose

The purpose of this PR is to ensure that the web audio samples provide a smooth and engaging experience for users. By addressing reported bugs and implementing enhancements, we aim to make the demos more useful and accessible to developers interested in web audio technologies.

Screenshots

bandicam2024-03-0822-44-52-351-ezgif com-crop

bandicam2024-03-0822-45-48-001-ezgif com-crop 4-4f8b-4650-bbdf-f652b23fcba0)

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

tarunsinghofficial commented 3 months ago

Any update on the PR?

tarunsinghofficial commented 3 months ago

Hi @hoch! I have made the required changes, let me know if they commit is now goog and ready to be merged. Thanks

tarunsinghofficial commented 2 months ago

Hi @hoch

Any update on this PR? I know that I created this issue under the GSoC tag, but please don't close this PR as it is great improvement in the web audio samples for chrome labs.

Thanks

hoch commented 2 months ago

Of course. We'll continue to work on this. The team is currently a bit behind schedule, so reviewing this PR will take some time. Thanks for your patience!

tarunsinghofficial commented 2 months ago

Of course. We'll continue to work on this. The team is currently a bit behind schedule, so reviewing this PR will take some time. Thanks for your patience!

Hi @hoch

Any update on this PR?

tarunsinghofficial commented 2 months ago

Is this PR still ongoing?

hoch commented 2 months ago

Yes. We will review the PR soon. Thanks for your patience.

tarunsinghofficial commented 1 month ago

Hi @hoch, I hope you're doing well! I have made all the necessary changes, and tested them locally, and as far as I know, it is ready to be merged to the main branch since all the requested changes have been completed.

GoogleChromeLabs / web-audio-samples