GoogleChromeLabs / web-audio-samples

Web Audio API samples by Chrome Web Audio Team
https://bit.ly/web-audio-samples
Apache License 2.0
686 stars 196 forks source link

Combine Free Queue and WASM Helper Ring Buffer Implementations #354

Closed MeenuyD closed 2 months ago

MeenuyD commented 6 months ago

Combine Free Queue and WASM Helper Ring Buffer Implementations

Objective: The objective of this issue is to combine two different implementations of a ring buffer into a single, cohesive implementation that incorporates the features and advantages of both the Free Queue and WASM Helper approaches.

Description: Currently, we have two separate implementations of a ring buffer:

Free Queue: This implementation provides a single-producer/single-consumer lock-free FIFO backed by SharedArrayBuffer. It is optimized for managing audio data in a multi-threaded environment. WASM Helper: This implementation utilizes WebAssembly (WASM) to optimize the ring buffer for single-threaded operation. It is designed to efficiently handle audio data in a single-threaded environment.

347

google-cla[bot] commented 6 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Daksh-10 commented 6 months ago

@MeenuyD you didn't signed the CLA, then only it will be allowed to merged. I am also learning and working on the same project.

MeenuyD commented 6 months ago

Oh nice I have signed the cla

hoch commented 6 months ago

IIUC this only adds a new file to the lib directory. I believe other files (the user of this library) will also need to be updated, and the redundant files should be removed.

MeenuyD commented 6 months ago

Yes I will do it as soon as possible

hoch commented 2 months ago

I am closing this because a similar task is completed by https://github.com/GoogleChromeLabs/web-audio-samples/pull/369. Thank you for your interest and contribution!