Open Shivam7-1 opened 3 months ago
Hi @mjwilson-google
I've made some significant changes in PR #355 , where I optimized buffer access in the RingBuffer class. I believe these changes could improve the performance of our project.
Could you please take a moment to review my PR? Your feedback would be greatly appreciated.
Additionally, I'm planning to apply for GSOC'24 and I'm particularly interested in this project. I believe that your insights would not only help improve my PR but also my application for GSOC'24.
Thank you for your time and consideration.
Best, Shivam
Optimize Buffer Access in RingBuffer Class Issue: https://github.com/GoogleChromeLabs/web-audio-samples/issues/347 Description:
This PR aims to optimize buffer access in the RingBuffer class by utilizing typed array views for more efficient data access. The changes improve performance by avoiding nested array accesses and directly accessing the underlying Float32Array.
Changes:
push
andpull
) in the RingBuffer class to utilize typed array views for accessing channel data._data
property of the RingBuffer class for improved efficiency.