search

GoogleChromeLabs / web-audio-samples

Web Audio API samples by Chrome Web Audio Team
https://bit.ly/web-audio-samples
Apache License 2.0
695 stars 197 forks source link

[Working Draft] Introduce Playwright test framework #368

Closed terryzfeng closed 4 months ago

terryzfeng commented 5 months ago

Preparing Playwright Test Framework for AudioWorklet Testing

Tests written here src/tests/playwright (.spec.ts) Test pages are in src/tests/playwrights/pages

More documentation is written here https://docs.google.com/document/d/1e7G9jc4kuVZWvjylTtFE76DzQBsOG6lZSFmV19Kc5cY/edit#heading=h.wb3akxg1nco

terryzfeng commented 5 months ago

I haven't yet figured out how to manage multiple versions of Chromium through Playwright, just have the latest Chromium build I believe.

terryzfeng commented 4 months ago

This looks great in general! I glanced 2/3 of files in this PR.

One recommendation - many comments and many files usually mean that we need to narrow the scope of the PR. Can we keep this PR for the iteration, and tease out a small part of this and focus on it? That will definitely make the review/landing faster.

I totally agree that this PR is much too big and quite complex. Thank you for taking the time to look at so much of it! I'm happy to remove extraneous features/functionality from this MVP. What's the best way to tease out a small part of this? With that, I think we would be able to wrap it up nicely this week!

hoch commented 4 months ago

For the first PR, how about focusing on src/tests/playwright/pages/realtime-sine.html and dependencies for it?