GoogleChromeLabs / web-audio-samples

Web Audio API samples by Chrome Web Audio Team
https://bit.ly/web-audio-samples
Apache License 2.0
686 stars 197 forks source link

Add Linting as a part of CI pipeline #392

Open tarunsinghofficial opened 3 weeks ago

tarunsinghofficial commented 3 weeks ago

Overview

We should add automated linting to our Continuous Integration (CI) pipeline to ensure consistent code style and catch potential errors early in the development process.

Current Situation

Proposed Solution

Add a linting step to our GitHub Actions workflow that runs on every pull request and push to main branches.

Implementation Details

  1. Create or update a GitHub Actions workflow file (e.g., .github/workflows/ci.yml).
  2. Add a linting job that includes:
    • Setting up Node.js
    • Installing dependencies
    • Running ESLint
    • (Optional) Running Prettier
tarunsinghofficial commented 3 weeks ago

I'm interested in doing this issue. Let me know if it is good, and please assign the issue to me. Thanks!

hoch commented 3 weeks ago

Sure thing. I'll assign this to you.

tarunsinghofficial commented 1 week ago

Sure thing. I'll assign this to you.

Hi @hoch

Please review PR #393, whenever you're free. Thanks :)

hoch commented 1 week ago

Yes. We will get to this soon after wrapping up the https://github.com/GoogleChromeLabs/web-audio-samples/pull/395. Thanks for your contribution!