search

GoogleChromeLabs / web-push-codelab

Other
557 stars 293 forks source link

Incorrect Preview of screenshots #24

Closed anujduggal88 closed 7 years ago

anujduggal88 commented 7 years ago

Incorrect Preview of screenshots

Issue:

The following screenshot indicates the developer to navigate to localhost:8887. The developer is not able to run the application with this URL:

screen shot 2016-11-29 at 10 54 15 am

Solution:

The developer needs to navigate to localhost:8887/app/ to run the application and see the changes made in the code.

screen shot 2016-11-29 at 11 29 50 am
gauntface commented 7 years ago

The codelab does say to set up up the 200 OK extension to point at app.

Click the choose folder button, and select the app folder.

anujduggal88 commented 7 years ago

@gauntface : But the screenshot is non-consistent with the codelab. The folder structure in the codelab is not the same as in screenshot - it misguides the developers, don't you think so?

gauntface commented 7 years ago

If you set the root of the server to 'app' the screenshot is correct.