Truncated text - Githubissues

GoogleChromeLabs / web-push-codelab

Other

556 stars 291 forks source link

Truncated text #35

Closed seanmtracey closed 7 years ago

seanmtracey commented 7 years ago

When attempting to test the push notifications tutorial with the push companion, the page complains that the subscription endpoint is truncated when it is not.

There are no further error messages.

Version 56.0.2924.87 (64-bit) OS X 10.10.5

seanmtracey commented 7 years ago

I think this line should be if (subscriptionObject.endpoint.indexOf('...') > -1) {

gauntface commented 7 years ago

Sorry - was a rushed PR - should be fixed shortly - in the process of deploying now.

seanmtracey commented 7 years ago

👍 I've made that mistake too :)