search

GoogleChromeLabs / web-push-codelab

Other
557 stars 293 forks source link

Images are not appearing on the docs #40

Closed thomaspessato closed 7 years ago

thomaspessato commented 7 years ago

There are some images on the doc that are not appearing.

This is one of them:

https://developers.google.com/web/fundamentals/getting-started/codelabs/push-notifications/img/cb84e05044ad029f.png

Right on the part where we should send the push from the external URL (out from the lab)

This is the URL that has missing images: https://developers.google.com/web/fundamentals/getting-started/codelabs/push-notifications/

gauntface commented 7 years ago

Can you possibly provide example text where the image doesn't load and a screenshot.

Looking at the source for the page, that image isn't linked anywhere and I can't see any broken images.

thomaspessato commented 7 years ago

My tutorial is in Portuguese, and I can't find anywhere to change it to another language, even though the left menu is in English. Sorry about that.

The images are right after the "function updateBtn()" declaration.

This is the screenshot.

sem titulo

gauntface commented 7 years ago

Ah, that helped a lot, thanks for the extra info.

If you scroll right to the bottom of the page, you'll see a toggle switch in the bottom left hand side of the footer where you can change language.

gauntface commented 7 years ago

I've raised an issue with Web fundamentals to see what the issue is: https://github.com/google/WebFundamentals/issues/4404