GoogleChromeLabs / web-push-codelab

Other
557 stars 293 forks source link

remove useless calculation #48

Closed nirsharma closed 6 years ago

nirsharma commented 6 years ago

removing extra %4, which doesn't do anything

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


nirsharma commented 6 years ago

I signed it!

googlebot commented 6 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

nirsharma commented 6 years ago

I fixed it!

googlebot commented 6 years ago

CLAs look good, thanks!