search

GoogleChromeLabs / webidl-diff

BSD 3-Clause "New" or "Revised" License
13 stars 13 forks source link

Change Built-in type Parsing #50

Open m-cheung opened 7 years ago

m-cheung commented 7 years ago

Currently, the BuiltInTypeName semantic rule is doing parsing built in types such as long, long long, unsigned long, etc. as seen here. A

We should update the rules to match the grammar defined in HeyCam's spec to avoid allowing text such as long long long

mdittmer commented 7 years ago

I would say this is a low priority. It is more important that our parser produce a correct AST for correct IDL than that it fail when IDL is invalid. I'm concerned that getting built in types exactly right will introduce complexity in a corner of the parser where the spec may change relatively frequently.