GoogleChromeLabs / webpack-libs-optimizations

Using a library in your webpack project? Here’s how to optimize it
Apache License 2.0
3.37k stars 111 forks source link

Add babel-plugin-transform-imports #1

Closed kurtextrem closed 6 years ago

kurtextrem commented 6 years ago

First PR of this repo? :D

Anyway, I hope it's fine that I've added a new section. I wasn't sure how to exactly name it, so I'm definitely open to suggestions.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


kurtextrem commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!

iamakulov commented 6 years ago

Wow, that’s a great addition!

Let me think a bit how to fit it in this repo (“Unspecified libraries” is a good option, but probably there’s another approach).

kurtextrem commented 6 years ago

Thank you for the review, really appreciated! I'll take a look as soon as possible.

kurtextrem commented 6 years ago

I've updated the PR to reflect your thoughts :)

Right as I saved the doc, I've seen that "Solutions that work with multiple libraries" is still surrounded by back-ticks, so it looks like a module. Let me know if you have any other ideas how to improve and I'll remove the back-ticks with the other findings.

An idea I'd have is to put the "Solutions that work with multiple libraries" section to the top instead of the bottom (+ replace the emojis). What do you think?

kurtextrem commented 6 years ago

I've corrected the last few things (also no one saw rooter instead of router *coughs :D)

iamakulov commented 6 years ago

Superb, thanks a lot!

kurtextrem commented 6 years ago

Nice! 🎉