GoogleChromeLabs / webpack-libs-optimizations

Using a library in your webpack project? Here’s how to optimize it
Apache License 2.0
3.37k stars 111 forks source link

Overhaul "Migrate to React alternatives" #13

Closed kurtextrem closed 6 years ago

kurtextrem commented 6 years ago

fixes #8

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

iamakulov commented 6 years ago

Sorry, it’s now me who failed to merge this in time :)

Thanks for the addition, looks really great!

I’ve tuned the text a bit; are these changes OK, or is something off?

https://github.com/GoogleChromeLabs/webpack-libs-optimizations/pull/13/commits/9276e0d1d6381fb5ad4dff06671783c3f7dbdb4c

kurtextrem commented 6 years ago

Changes look really good!

iamakulov commented 6 years ago

Thanks for the PR :)