GoogleChromeLabs / webpack-libs-optimizations

Using a library in your webpack project? Here’s how to optimize it
Apache License 2.0
3.37k stars 111 forks source link

Change react-bootstrap transform #5

Closed felipeleusin closed 6 years ago

felipeleusin commented 6 years ago

You can use transform-imports to load the react-bootstrap es version instead of the lib to have better access to tree shaking.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
iamakulov commented 6 years ago

That’s a great catch, thanks :–)

Looking forward to merge this once the CLA is signed.

felipeleusin commented 6 years ago

Just signed it. Should be up soon. Thanks!

googlebot commented 6 years ago

CLAs look good, thanks!

iamakulov commented 6 years ago

\o/