GoogleChromeLabs / worker-plugin

👩‍🏭 Adds native Web Worker bundling support to Webpack.
https://npm.im/worker-plugin
Apache License 2.0
1.92k stars 79 forks source link

Update README.md #28

Closed futurechallenger closed 5 years ago

futurechallenger commented 5 years ago

When there's no any configuration in new WorkerPlugin(), there would be such a warning message:

Warning (worker-plugin): output.globalObject is set to "window". It must be set to "self" to support HMR in Workers.

So It seems the default value is window, and it's incorrect in the README.md reads that the default value is self.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.