GoogleChromeLabs / worker-plugin

👩‍🏭 Adds native Web Worker bundling support to Webpack.
https://npm.im/worker-plugin
Apache License 2.0
1.91k stars 79 forks source link

Fix `Module parse failed: Cannot read property 'length' of undefined` #94

Closed jebbench closed 3 years ago

jebbench commented 3 years ago

Fix for https://github.com/GoogleChromeLabs/worker-plugin/issues/93

Checks that optsExpr.properties is defined.

googlebot commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

jebbench commented 3 years ago

@googlebot I signed it!

googlebot commented 3 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

dcantu476 commented 3 years ago

Is there anything outstanding that would prevent this from being merged in? This fixed the issue I was having with the mentioned auth0 library.

iplaksiy commented 3 years ago

Seconding @dcantu476. Angular will not build unless I update this manually.

mgreg89 commented 3 years ago

@developit Can you merge this PR? Would really appreciate it! :)

AntonyChiossi commented 3 years ago

Can you please merge this :) ? @developit

it causes also some problem with Web workers

steps:

more details can be found here:

https://github.com/ng-web-apis/workers/issues/7

developit commented 3 years ago

Apologies for taking so long to merge this.

developit commented 3 years ago

Published as 5.0.1.