Bail early if there are no sitemap entries - Githubissues

GoogleChromeLabs / wp-sitemaps

Proposal to integrate basic XML Sitemaps in WordPress Core

GNU General Public License v2.0

97 stars 26 forks source link

Bail early if there are no sitemap entries #190

Closed swissspidy closed 4 years ago

swissspidy commented 4 years ago

Issue Number

Fixes #186.

Description

On PHP < 7.3, array_push emits a warning if the second param is an empty array. See https://3v4l.org/Pk7En and https://www.php.net/manual/en/function.array-push.php

This PR checks whether the sitemap entries array is empty before trying to array_push it.

Type of change

Please select the relevant options:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (change which improves an existing feature. E.g., performance improvement, docs update, etc.)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Steps to test

Run tests on PHP < 7.3

Acceptance criteria

[x] My code follows WordPress coding standards.
[x] I have performed a self-review of my own code.
[ ] If the changes are visual, I have cross browser / device tested.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I have added test instructions that prove my fix is effective or that my feature works.