Closed talatuyarer closed 5 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
should we also add .flattened-pom.xml files to the .gitignore?
We sould not. flatten poms are created under target folder which is on .gitignore : https://github.com/GoogleCloudDataproc/flink-bigquery-connector/blob/main/.gitignore#L1
/gcbrun
/gcbrun
Current main branch build generate having POM containing ${revision} has version.
This is neatly explained in the official maven documentation: https://maven.apache.org/maven-ci-friendly.html#install-deploy I updated main pom with official suggestion. Currently it works on my machine.