GoogleCloudDataproc / flink-bigquery-connector

BigQuery integration to Apache Flink's Table API
Apache License 2.0
15 stars 11 forks source link

Local build generate non consumable pom files #115

Closed talatuyarer closed 5 months ago

talatuyarer commented 5 months ago

Current main branch build generate having POM containing ${revision} has version.

Screenshot 2024-04-30 at 5 26 57 PM

This is neatly explained in the official maven documentation: https://maven.apache.org/maven-ci-friendly.html#install-deploy I updated main pom with official suggestion. Currently it works on my machine.

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

clmccart commented 5 months ago

should we also add .flattened-pom.xml files to the .gitignore?

talatuyarer commented 5 months ago

We sould not. flatten poms are created under target folder which is on .gitignore : https://github.com/GoogleCloudDataproc/flink-bigquery-connector/blob/main/.gitignore#L1

jayehwhyehentee commented 5 months ago

/gcbrun

jayehwhyehentee commented 5 months ago

/gcbrun