GoogleCloudDataproc / flink-bigquery-connector

BigQuery integration to Apache Flink's Table API
Apache License 2.0
15 stars 11 forks source link

Optimization for handleUnionSchema. #119

Closed prashastia closed 4 months ago

prashastia commented 5 months ago

Replaces the existing implementation with an if-else based to increase performance.

@talatuyarer - Please have a look.

/gcbrun

talatuyarer commented 4 months ago

@prashastia The change looks good to me. However I dont have permission to approve your PR.

prashastia commented 4 months ago

@prashastia The change looks good to me. However I dont have permission to approve your PR.

Thanks!, Could you kindly add yourself as a reviewer and then try?

jayehwhyehentee commented 4 months ago

@clmccart We need to find a way for GMF folks with GitHub accounts to be able to review or even contribute to this project. Any suggestions?

clmccart commented 4 months ago

@clmccart We need to find a way for GMF folks with GitHub accounts to be able to review or even contribute to this project. Any suggestions?

i think you'll have to reach out to the repo owners and ask them to add us as contributors to the repo