GoogleCloudDataproc / flink-bigquery-connector

BigQuery integration to Apache Flink's Table API
Apache License 2.0
15 stars 11 forks source link

fix: BQ partition utils intervals #146

Closed amstee closed 1 month ago

amstee commented 1 month ago

👋 been having an issue with the query restriction generated by the connector when running in unbounded mode.

The BETWEEN operator is inclusive: begin and end values are included. this causes the source connector to read some of the data twice.

This change should fix that, let me know if there's any test I may have missed !

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

amstee commented 1 month ago

@prashastia if you could review 🙏

jayehwhyehentee commented 1 month ago

/gcbrun

amstee commented 1 month ago

Hey, thanks for the review, any blocker @jayehwhyehentee ?

jayehwhyehentee commented 1 month ago

@amstee merged