search

GoogleCloudPlatform / DataflowJavaSDK

Google Cloud Dataflow provides a simple, powerful model for building both batch and streaming parallel data processing pipelines.
http://cloud.google.com/dataflow
855 stars 324 forks source link

Backport ValueProvider from [BEAM-551] #492

Closed sammcveety closed 7 years ago

sammcveety commented 7 years ago

R: @davorbonaci

davorbonaci commented 7 years ago

R: @dhalperi, for more context

dhalperi commented 7 years ago

For reviewing purposes, which Beam PR is this a backport of? Need to be able to compare diffs 1-1 to confirm backport success.

sammcveety commented 7 years ago

https://github.com/apache/incubator-beam/pull/852 https://github.com/apache/incubator-beam/pull/1009 https://github.com/apache/incubator-beam/pull/1105 https://github.com/apache/incubator-beam/pull/1107 https://github.com/apache/incubator-beam/pull/1146 https://github.com/apache/incubator-beam/pull/1156 https://github.com/apache/incubator-beam/pull/1266 https://github.com/apache/incubator-beam/pull/1503 https://github.com/apache/incubator-beam/pull/1549 https://github.com/apache/incubator-beam/pull/1575

sammcveety commented 7 years ago

retest this please

davorbonaci commented 7 years ago

"retest this please" doesn't work in Dataflow, only Beam. I kicked the build through the Travis UI.

sammcveety commented 7 years ago

Done

dhalperi commented 7 years ago

LGTM: https://www.diffchecker.com/FsAidkqL

Will merge once green.