search

GoogleCloudPlatform / DataflowJavaSDK

Google Cloud Dataflow provides a simple, powerful model for building both batch and streaming parallel data processing pipelines.
http://cloud.google.com/dataflow
855 stars 324 forks source link

Fix InProcessPipelineRunner to handle a null subscription #547

Closed sammcveety closed 7 years ago

sammcveety commented 7 years ago

R: @tgroh

sammcveety commented 7 years ago

For verifying the subscription, is the least-bad way I can see is to make an additional factory method that includes a verifyCreateSubscription toggle. Anything nicer than that?

dhalperi commented 7 years ago

Is this fixing the same bug as https://github.com/apache/beam/commit/4406414a52e45213de5521bff4a7599b8aa53a71 ?

Thoughts on a more direct backport?

dhalperi commented 7 years ago

better link: https://github.com/apache/beam/pull/1817

sammcveety commented 7 years ago

I think this is a different issue (not present in Beam), made obsolete by the new structure of the function in question.

On Tue, Feb 14, 2017 at 9:31 AM, Daniel Halperin notifications@github.com wrote:

better link: apache/beam#1817 https://github.com/apache/beam/pull/1817

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/DataflowJavaSDK/pull/547#issuecomment-279776707, or mute the thread https://github.com/notifications/unsubscribe-auth/ACQVgeOymSRIOAwP6UwqlIR-XJhMM597ks5rceTdgaJpZM4L1p5d .

tgroh commented 7 years ago

I don't think there's anything nicer than that, but I'm not particularly bothered (given that it's a PubsubTestClientFactory)

sammcveety commented 7 years ago

Done, please take another look.