search

GoogleCloudPlatform / DataflowJavaSDK

Google Cloud Dataflow provides a simple, powerful model for building both batch and streaming parallel data processing pipelines.
http://cloud.google.com/dataflow
855 stars 324 forks source link

Fixed documentation #562

Closed anilmuppalla closed 7 years ago

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

dhalperi commented 7 years ago

Valid corporate CLA for Spotify, github doesn't have the user's email linked to this account but checked manually.

dhalperi commented 7 years ago

Thanks for this nice fixup.

dhalperi commented 7 years ago

Btw, would you also send a PR to Apache Beam, which is the basis of Dataflow 2? Looks like we have the same bug there: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/AfterWatermark.java

anilmuppalla commented 7 years ago

done. https://github.com/apache/beam/pull/2444