GoogleCloudPlatform / DataflowTemplates

Cloud Dataflow Google-provided templates for solving in-Cloud data tasks
https://cloud.google.com/dataflow/docs/guides/templates/provided-templates
Apache License 2.0
1.12k stars 936 forks source link

Add TLS authentication support for Kafka Templates #1636

Closed Dippatel98 closed 1 month ago

AnandInguva commented 1 month ago

One thing I forgot: we might want to remove the skipOptions related to TLS

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.48%. Comparing base (74266d7) to head (7d0aa0a).

:exclamation: Current head 7d0aa0a differs from pull request most recent head 9418225

Please upload reports for the commit 9418225 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1636 +/- ## ============================================ + Coverage 41.24% 41.48% +0.23% + Complexity 2931 2917 -14 ============================================ Files 760 754 -6 Lines 44313 43977 -336 Branches 4745 4707 -38 ============================================ - Hits 18278 18244 -34 + Misses 24492 24192 -300 + Partials 1543 1541 -2 ``` | [Components](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [spanner-templates](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `61.23% <ø> (-0.02%)` | :arrow_down: | | [spanner-import-export](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `64.34% <ø> (-0.09%)` | :arrow_down: | | [spanner-live-forward-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `73.56% <ø> (+0.07%)` | :arrow_up: | | [spanner-live-reverse-replication](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `49.15% <ø> (+0.03%)` | :arrow_up: | | [spanner-bulk-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `81.91% <ø> (+0.07%)` | :arrow_up: | | [Files](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [...oud/teleport/v2/templates/KafkaToBigQueryFlex.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636?src=pr&el=tree&filepath=v2%2Fkafka-to-bigquery%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2FKafkaToBigQueryFlex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIva2Fma2EtdG8tYmlncXVlcnkvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3YyL3RlbXBsYXRlcy9LYWZrYVRvQmlnUXVlcnlGbGV4LmphdmE=) | `0.00% <ø> (ø)` | | | [...le/cloud/teleport/v2/templates/KafkaToGcsFlex.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636?src=pr&el=tree&filepath=v2%2Fkafka-to-gcs%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2FKafkaToGcsFlex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIva2Fma2EtdG8tZ2NzL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi90ZW1wbGF0ZXMvS2Fma2FUb0djc0ZsZXguamF2YQ==) | `0.00% <ø> (ø)` | | ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1636/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform)
AnandInguva commented 1 month ago

@Dippatel98 let's merge the cl and the PR.