search

GoogleCloudPlatform / DataflowTemplates

Cloud Dataflow Google-provided templates for solving in-Cloud data tasks
https://cloud.google.com/dataflow/docs/guides/templates/provided-templates
Apache License 2.0
1.14k stars 960 forks source link

Add datastream to sql IT's #1697

Closed Polber closed 2 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 29.88506% with 61 lines in your changes missing coverage. Please review.

Project coverage is 41.23%. Comparing base (0bcf179) to head (7e440c4). Report is 67 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1697 +/- ## ============================================ - Coverage 41.25% 41.23% -0.03% + Complexity 3240 2936 -304 ============================================ Files 771 772 +1 Lines 45127 45209 +82 Branches 4819 4826 +7 ============================================ + Hits 18619 18640 +21 - Misses 24940 24996 +56 - Partials 1568 1573 +5 ``` | [Components](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [spanner-templates](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `61.25% <ø> (ø)` | | | [spanner-import-export](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `64.36% <ø> (ø)` | | | [spanner-live-forward-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `74.14% <ø> (ø)` | | | [spanner-live-reverse-replication](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `50.56% <ø> (ø)` | | | [spanner-bulk-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `80.63% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [...eam/it/gcp/cloudsql/CloudMySQLResourceManager.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697?src=pr&el=tree&filepath=it%2Fgoogle-cloud-platform%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fit%2Fgcp%2Fcloudsql%2FCloudMySQLResourceManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-aXQvZ29vZ2xlLWNsb3VkLXBsYXRmb3JtL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9iZWFtL2l0L2djcC9jbG91ZHNxbC9DbG91ZE15U1FMUmVzb3VyY2VNYW5hZ2VyLmphdmE=) | `83.33% <60.00%> (-16.67%)` | :arrow_down: | | [.../beam/it/gcp/cloudsql/CloudSqlResourceManager.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697?src=pr&el=tree&filepath=it%2Fgoogle-cloud-platform%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fit%2Fgcp%2Fcloudsql%2FCloudSqlResourceManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-aXQvZ29vZ2xlLWNsb3VkLXBsYXRmb3JtL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9iZWFtL2l0L2djcC9jbG91ZHNxbC9DbG91ZFNxbFJlc291cmNlTWFuYWdlci5qYXZh) | `79.48% <85.71%> (+1.02%)` | :arrow_up: | | [...am/it/gcp/cloudsql/CloudOracleResourceManager.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697?src=pr&el=tree&filepath=it%2Fgoogle-cloud-platform%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fit%2Fgcp%2Fcloudsql%2FCloudOracleResourceManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-aXQvZ29vZ2xlLWNsb3VkLXBsYXRmb3JtL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9iZWFtL2l0L2djcC9jbG91ZHNxbC9DbG91ZE9yYWNsZVJlc291cmNlTWFuYWdlci5qYXZh) | `70.58% <61.11%> (-14.42%)` | :arrow_down: | | [.../it/gcp/cloudsql/CloudPostgresResourceManager.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697?src=pr&el=tree&filepath=it%2Fgoogle-cloud-platform%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fit%2Fgcp%2Fcloudsql%2FCloudPostgresResourceManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-aXQvZ29vZ2xlLWNsb3VkLXBsYXRmb3JtL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9iZWFtL2l0L2djcC9jbG91ZHNxbC9DbG91ZFBvc3RncmVzUmVzb3VyY2VNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1697/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform)
Polber commented 2 months ago

@damccorm Do you mind taking a look when you get a chance?