search

GoogleCloudPlatform / DataflowTemplates

Cloud Dataflow Google-provided templates for solving in-Cloud data tasks
https://cloud.google.com/dataflow/docs/guides/templates/provided-templates
Apache License 2.0
1.14k stars 950 forks source link

Fix for mutated failsafe event #1734

Closed shreyakhajanchi closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.40%. Comparing base (fc02f34) to head (a0a689e). Report is 61 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1734 +/- ## ========================================= Coverage 48.40% 48.40% Complexity 996 996 ========================================= Files 327 327 Lines 17709 17708 -1 Branches 1775 1775 ========================================= Hits 8572 8572 + Misses 8546 8545 -1 Partials 591 591 ``` | [Components](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [spanner-templates](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `63.17% <63.33%> (+<0.01%)` | :arrow_up: | | [spanner-import-export](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `∅ <ø> (∅)` | | | [spanner-live-forward-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `75.00% <98.57%> (+0.02%)` | :arrow_up: | | [spanner-live-reverse-replication](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `51.54% <100.00%> (ø)` | | | [spanner-bulk-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `83.14% <60.62%> (ø)` | | | [Files](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [...oud/teleport/v2/templates/DataStreamToSpanner.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734?src=pr&el=tree&filepath=v2%2Fdatastream-to-spanner%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2FDataStreamToSpanner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvZGF0YXN0cmVhbS10by1zcGFubmVyL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi90ZW1wbGF0ZXMvRGF0YVN0cmVhbVRvU3Bhbm5lci5qYXZh) | `5.84% <ø> (ø)` | | | [...ort/v2/templates/SpannerTransactionWriterDoFn.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734?src=pr&el=tree&filepath=v2%2Fdatastream-to-spanner%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2FSpannerTransactionWriterDoFn.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvZGF0YXN0cmVhbS10by1zcGFubmVyL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi90ZW1wbGF0ZXMvU3Bhbm5lclRyYW5zYWN0aW9uV3JpdGVyRG9Gbi5qYXZh) | `68.18% <ø> (+0.76%)` | :arrow_up: | | [...emplates/transform/ChangeEventTransformerDoFn.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734?src=pr&el=tree&filepath=v2%2Fdatastream-to-spanner%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2Ftransform%2FChangeEventTransformerDoFn.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvZGF0YXN0cmVhbS10by1zcGFubmVyL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi90ZW1wbGF0ZXMvdHJhbnNmb3JtL0NoYW5nZUV2ZW50VHJhbnNmb3JtZXJEb0ZuLmphdmE=) | `88.65% <100.00%> (ø)` | | ... and [23 files with indirect coverage changes](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1734/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform)
manitgupta commented 1 month ago

Can you give me the code reference of the commit where this was changed? I want to look at what happened once.

shreyakhajanchi commented 1 month ago

Can you give me the code reference of the commit where this was changed? I want to look at what happened once.

https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1441/files#diff-e59a1073b170fe6c799c581e58d89d709417bb7cd1218dfd57690b0444db5911

shreyakhajanchi commented 1 month ago

I will add an integration test as a follow up with Fks and modified schema