Closed Polber closed 1 month ago
Not sure why checks aren't running. Looking into it
Might be this https://www.githubstatus.com/
wait, at least need to add this line in several places per #1681
RowJsonUtils.increaseDefaultStreamReadConstraints(100 * 1024 * 1024);
Job is queued: https://github.com/GoogleCloudPlatform/DataflowTemplates/actions/runs/10000088771 Definitely a github issue. Don't love that it doesn't block submission
there will be integration test failures which I observed during 2.57.0rc1 validation, need to fix some code path, see https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1739#issuecomment-2237776829
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 42.31%. Comparing base (
d7db191
) to head (84d72c6
).
there will be integration test failures which I observed during 2.57.0rc1 validation, need to fix some code path, see #1739 (comment)
@Abacn I already included these changes when I upgraded beam in #1695.
IT's passed other than a couple Kafka IT's which have already been failing - I'm looking into those, but error is unrelated to the jackson upgrade.
Apache Beam depends on Jackson 2.15.4 as of https://github.com/apache/beam/pull/31473 which is breaking at least the JMS To PubSub template when deserializing pipeline options due to
which was a field added in 2.15.4