search

GoogleCloudPlatform / DataflowTemplates

Cloud Dataflow Google-provided templates for solving in-Cloud data tasks
https://cloud.google.com/dataflow/docs/guides/templates/provided-templates
Apache License 2.0
1.15k stars 967 forks source link

Add CommonTemplateJvmInitializerIT #1745

Open Polber opened 3 months ago

Polber commented 3 months ago

Follow up to #1744

Adds IT's to ensure that CommonTemplateJvmInitializer.beforeProcessing() is called by Dataflow worker before executing pipeline.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 42.30%. Comparing base (5be5817) to head (c0434f5). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1745 +/- ## ============================================ - Coverage 42.31% 42.30% -0.01% Complexity 3181 3181 ============================================ Files 794 796 +2 Lines 46244 46257 +13 Branches 4951 4950 -1 ============================================ + Hits 19569 19571 +2 - Misses 25077 25087 +10 - Partials 1598 1599 +1 ``` | [Components](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [spanner-templates](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `63.69% <ø> (-0.01%)` | :arrow_down: | | [spanner-import-export](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `64.42% <ø> (-0.03%)` | :arrow_down: | | [spanner-live-forward-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `74.97% <ø> (ø)` | | | [spanner-live-reverse-replication](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `51.84% <ø> (ø)` | | | [spanner-bulk-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `82.79% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [...oud/teleport/plugin/TemplateDefinitionsParser.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745?src=pr&el=tree&filepath=plugins%2Fcore-plugin%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fplugin%2FTemplateDefinitionsParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-cGx1Z2lucy9jb3JlLXBsdWdpbi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdGVsZXBvcnQvcGx1Z2luL1RlbXBsYXRlRGVmaW5pdGlvbnNQYXJzZXIuamF2YQ==) | `11.53% <0.00%> (+0.42%)` | :arrow_up: | | [...eport/templates/common/JvmInitializerTemplate.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Ftemplates%2Fcommon%2FJvmInitializerTemplate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3RlbXBsYXRlcy9jb21tb24vSnZtSW5pdGlhbGl6ZXJUZW1wbGF0ZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...oud/teleport/v2/common/JvmInitializerTemplate.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745?src=pr&el=tree&filepath=v2%2Fcommon%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Fcommon%2FJvmInitializerTemplate.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi9jb21tb24vSnZtSW5pdGlhbGl6ZXJUZW1wbGF0ZS5qYXZh) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1745/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform)