search

GoogleCloudPlatform / DataflowTemplates

Cloud Dataflow Google-provided templates for solving in-Cloud data tasks
https://cloud.google.com/dataflow/docs/guides/templates/provided-templates
Apache License 2.0
1.15k stars 967 forks source link

code refactoring common code reuse #1766

Closed aksharauke closed 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 83.05085% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (fc4ca2b) to head (a0001bf).

Files Patch % Lines
...ations/convertors/ChangeEventSpannerConvertor.java 77.77% 7 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1766 +/- ## ============================================ + Coverage 42.87% 42.94% +0.06% - Complexity 3399 3692 +293 ============================================ Files 815 815 Lines 47718 47632 -86 Branches 5111 5109 -2 ============================================ - Hits 20460 20456 -4 + Misses 25599 25514 -85 - Partials 1659 1662 +3 ``` | [Components](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [spanner-templates](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `63.74% <83.05%> (+0.36%)` | :arrow_up: | | [spanner-import-export](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `64.34% <ø> (-0.09%)` | :arrow_down: | | [spanner-live-forward-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `75.10% <80.00%> (-0.03%)` | :arrow_down: | | [spanner-live-reverse-replication](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `71.62% <81.48%> (+1.79%)` | :arrow_up: | | [spanner-bulk-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `83.63% <77.77%> (-0.07%)` | :arrow_down: | | [Files](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [...rt/v2/templates/datastream/ChangeEventContext.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766?src=pr&el=tree&filepath=v2%2Fdatastream-to-spanner%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2Fdatastream%2FChangeEventContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvZGF0YXN0cmVhbS10by1zcGFubmVyL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi90ZW1wbGF0ZXMvZGF0YXN0cmVhbS9DaGFuZ2VFdmVudENvbnRleHQuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [.../v2/templates/datastream/ChangeEventConvertor.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766?src=pr&el=tree&filepath=v2%2Fdatastream-to-spanner%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2Fdatastream%2FChangeEventConvertor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvZGF0YXN0cmVhbS10by1zcGFubmVyL3NyYy9tYWluL2phdmEvY29tL2dvb2dsZS9jbG91ZC90ZWxlcG9ydC92Mi90ZW1wbGF0ZXMvZGF0YXN0cmVhbS9DaGFuZ2VFdmVudENvbnZlcnRvci5qYXZh) | `81.94% <100.00%> (+0.69%)` | :arrow_up: | | [...leport/v2/templates/transforms/SourceWriterFn.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766?src=pr&el=tree&filepath=v2%2Fspanner-to-sourcedb%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Ftemplates%2Ftransforms%2FSourceWriterFn.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvc3Bhbm5lci10by1zb3VyY2VkYi9zcmMvbWFpbi9qYXZhL2NvbS9nb29nbGUvY2xvdWQvdGVsZXBvcnQvdjIvdGVtcGxhdGVzL3RyYW5zZm9ybXMvU291cmNlV3JpdGVyRm4uamF2YQ==) | `66.66% <100.00%> (+34.52%)` | :arrow_up: | | [...ations/convertors/ChangeEventSpannerConvertor.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766?src=pr&el=tree&filepath=v2%2Fspanner-common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fv2%2Fspanner%2Fmigrations%2Fconvertors%2FChangeEventSpannerConvertor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djIvc3Bhbm5lci1jb21tb24vc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3YyL3NwYW5uZXIvbWlncmF0aW9ucy9jb252ZXJ0b3JzL0NoYW5nZUV2ZW50U3Bhbm5lckNvbnZlcnRvci5qYXZh) | `80.43% <77.77%> (-3.57%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1766/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform)