GoogleCloudPlatform / DataflowTemplates

Cloud Dataflow Google-provided templates for solving in-Cloud data tasks
https://cloud.google.com/dataflow/docs/guides/templates/provided-templates
Apache License 2.0
1.14k stars 950 forks source link

Added support for search indexes #1768

Closed atask-g closed 1 month ago

atask-g commented 1 month ago

Extended InformationSchemaScanner to support search indexes:

R: @darshan-sj

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 42.97%. Comparing base (63072f4) to head (dedd322). Report is 22 commits behind head on main.

Files Patch % Lines
...a/com/google/cloud/teleport/spanner/ddl/Index.java 0.00% 4 Missing and 3 partials :warning:
.../com/google/cloud/teleport/spanner/ddl/Column.java 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1768 +/- ## ============================================ + Coverage 42.32% 42.97% +0.65% - Complexity 3182 3398 +216 ============================================ Files 794 815 +21 Lines 46244 47655 +1411 Branches 4951 5117 +166 ============================================ + Hits 19572 20481 +909 - Misses 25074 25514 +440 - Partials 1598 1660 +62 ``` | [Components](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [spanner-templates](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `64.71% <63.63%> (+1.01%)` | :arrow_up: | | [spanner-import-export](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `64.47% <63.63%> (+0.03%)` | :arrow_up: | | [spanner-live-forward-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `75.41% <ø> (+0.43%)` | :arrow_up: | | [spanner-live-reverse-replication](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `52.49% <ø> (+0.65%)` | :arrow_up: | | [spanner-bulk-migration](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | `83.63% <ø> (+0.83%)` | :arrow_up: | | [Files](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform) | Coverage Δ | | |---|---|---| | [...oud/teleport/spanner/AvroSchemaToDdlConverter.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2FAvroSchemaToDdlConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvQXZyb1NjaGVtYVRvRGRsQ29udmVydGVyLmphdmE=) | `78.59% <100.00%> (+0.61%)` | :arrow_up: | | [...va/com/google/cloud/teleport/spanner/AvroUtil.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2FAvroUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvQXZyb1V0aWwuamF2YQ==) | `93.75% <ø> (ø)` | | | [...oud/teleport/spanner/DdlToAvroSchemaConverter.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2FDdlToAvroSchemaConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvRGRsVG9BdnJvU2NoZW1hQ29udmVydGVyLmphdmE=) | `90.68% <100.00%> (+0.04%)` | :arrow_up: | | [...oogle/cloud/teleport/spanner/common/SizedType.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2Fcommon%2FSizedType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvY29tbW9uL1NpemVkVHlwZS5qYXZh) | `91.62% <100.00%> (+0.14%)` | :arrow_up: | | [...com/google/cloud/teleport/spanner/common/Type.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2Fcommon%2FType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvY29tbW9uL1R5cGUuamF2YQ==) | `90.18% <100.00%> (+0.13%)` | :arrow_up: | | [.../apache/beam/sdk/io/gcp/spanner/SpannerSchema.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fsdk%2Fio%2Fgcp%2Fspanner%2FSpannerSchema.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2JlYW0vc2RrL2lvL2djcC9zcGFubmVyL1NwYW5uZXJTY2hlbWEuamF2YQ==) | `65.42% <100.00%> (+0.65%)` | :arrow_up: | | [.../com/google/cloud/teleport/spanner/ddl/Column.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2Fddl%2FColumn.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvZGRsL0NvbHVtbi5qYXZh) | `78.65% <80.00%> (+1.27%)` | :arrow_up: | | [...a/com/google/cloud/teleport/spanner/ddl/Index.java](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768?src=pr&el=tree&filepath=v1%2Fsrc%2Fmain%2Fjava%2Fcom%2Fgoogle%2Fcloud%2Fteleport%2Fspanner%2Fddl%2FIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform#diff-djEvc3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2Nsb3VkL3RlbGVwb3J0L3NwYW5uZXIvZGRsL0luZGV4LmphdmE=) | `76.13% <0.00%> (-6.80%)` | :arrow_down: | ... and [47 files with indirect coverage changes](https://app.codecov.io/gh/GoogleCloudPlatform/DataflowTemplates/pull/1768/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GoogleCloudPlatform)