GoogleCloudPlatform / Open_Data_QnA

The Open Data QnA python library enables you to chat with your databases by leveraging LLM Agents on Google Cloud. Open Data QnA enables a conversational approach to interacting with your data by implementing state-of-the-art NL2SQL / Text2SQL methods.
Apache License 2.0
103 stars 35 forks source link

Redundant inference in BuildSQLAgent? #42

Open rafi-rr opened 2 months ago

rafi-rr commented 2 months ago

I was going over the inferences that the code performs and my understanding is that there's no point in performing the send_message call below if there was no previous question/SQL. I can suggest a simple PR to avoid if these values are None. What do you think?

https://github.com/GoogleCloudPlatform/Open_Data_QnA/blob/3075ebc7615544299b237009f9b5c88a9c177537/agents/BuildSQLAgent.py#L128