GoogleCloudPlatform / PerfKitBenchmarker

PerfKit Benchmarker (PKB) contains a set of benchmarks to measure and compare cloud offerings. The benchmarks use default settings to reflect what most users will see. PerfKit Benchmarker is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.
https://googlecloudplatform.github.io/PerfKitBenchmarker/
Apache License 2.0
1.89k stars 480 forks source link

Add `--skip_teardown_keep_up_minutes` flag to go alongside the `--skip_teardown_conditions`. #5001

Closed copybara-service[bot] closed 1 month ago

copybara-service[bot] commented 1 month ago

Add --skip_teardown_keep_up_minutes flag to go alongside the --skip_teardown_conditions.

When PKB skips teardown, the --keep_up_time determines how long the benchmark VMs should be kept alive. Note that this only updates the VMs' timeout_utc tags. Since the benchmark stops after skipping teardown, PKB will not teardown the VMs after the --keep_up_time is exceeded. The timeout annotation is used to determine when a user should tear down the VM themselves.

This also adds kept_alive:true to the metadata to make it clear that this VM has lingered after a benchmark run has completed.

The UpdateTimeoutMetadata function is currently implemented for GCP only.