search

GoogleCloudPlatform / PerfKitExplorer

PerfKit Explorer is a dashboarding and performance analysis tool built with Google technologies and easily extensible. PerfKit Explorer is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.
Apache License 2.0
267 stars 64 forks source link

Add explorer state #159

Closed jmuharsky closed 9 years ago

jmuharsky commented 9 years ago

Adds the management classes (Service and Model) for Explorer State, based on the current values in the Angular UI Router state service. At the moment, these services are loaded but unused; additional PR's will consolidate the dashboard's selection state into this service.

For more info, see the Design Doc

klausw commented 9 years ago

LGTM.

Optionally, consider squashing these changes and deferring merging this until you have implemented a use case for it. Personally I often find myself needing to make changes to APIs once they get used in practice. But it's also ok to make needed fixes later.

jmuharsky commented 9 years ago

That's fair. In actuality, the branch router_widgetselect has the "in practice" integration. This PR represents a cleanup after getting it all working.