GoogleCloudPlatform / PerfKitExplorer

PerfKit Explorer is a dashboarding and performance analysis tool built with Google technologies and easily extensible. PerfKit Explorer is licensed under the Apache 2 license terms. Please make sure to read, understand and agree to the terms of the LICENSE and CONTRIBUTING files before proceeding.
Apache License 2.0
267 stars 64 forks source link

Enable compiler warnings, fix type warnings. #237

Closed klausw closed 8 years ago

klausw commented 8 years ago

This is not complete, I've fixed ~500 of 600 type warnings, mainly missing imports and superficial errors.

This includes a few code changes where the fix was fairly obvious. I've kept these in individual commits for easier reviewing.

The remaining warnings are cases where it wasn't immediately obvious how to fix them, for example type declarations where I was unsure which type was intended, or genuine mismatches such as missing arguments and inconsistent types.

klausw commented 8 years ago

PTAL, I've rebased the changes to current master.

klausw commented 8 years ago

Test instance: https://klausw-jswarnings-dot-perfkit-explorer.appspot.com

I"m seeing some Karma test failures, investigating.

klausw commented 8 years ago

Karma test failures were spurious, all are passing as expected after resync + recompile.

jmuharsky commented 8 years ago

LGTM